CVE-2024-52811: Acks not validated before logged to qlog leads to buffer overflow in ngtcp2
The ngtcp2 project is an effort to implement IETF QUIC protocol in C. In affected versions acks are not validated before being written to the qlog leading to a buffer overflow. In `ngtcp2_conn::conn_recv_pkt` for an ACK, there was new logic that got added to skip `conn_recv_ack` if an ack has already been processed in the payload. However, this causes us to also skip `ngtcp2_pkt_validate_ack`. The ack which was skipped still got written to qlog. The bug occurs in `ngtcp2_qlog::write_ack_frame`. It is now possible to reach this code with an invalid ack, suppose `largest_ack=0` and `first_ack_range=15`. Subtracting `largest_ack - first_ack_range` will lead to an integer underflow which is 20 chars long. However, the ngtcp2 qlog code assumes the number written is a signed integer and only accounts for 19 characters of overhead (see `NGTCP2_QLOG_ACK_FRAME_RANGE_OVERHEAD`). Therefore, we overwrite the buffer causing a heap overflow. This is high priority and could potentially impact many users if they enable qlog. qlog is disabled by default. Due to its overhead, it is most likely used for debugging purpose, but the actual use is unknown. ngtcp2 v1.9.1 fixes the bug and users are advised to upgrade. Users unable to upgrade should not turn on qlog.
Affected Software
Event History
Frequently Asked Questions
What is the severity of CVE-2024-52811?
The severity of CVE-2024-52811 is classified as high due to the potential for a buffer overflow leading to exploitation.
How do I fix CVE-2024-52811?
To fix CVE-2024-52811, upgrade ngtcp2 to version 1.9.1 or later where the vulnerability has been addressed.
What versions of ngtcp2 are affected by CVE-2024-52811?
CVE-2024-52811 affects ngtcp2 versions prior to 1.9.1.
What type of vulnerability is CVE-2024-52811?
CVE-2024-52811 is a buffer overflow vulnerability related to ACK validation in the ngtcp2 implementation of the QUIC protocol.
Who is impacted by CVE-2024-52811?
Users and developers relying on vulnerable versions of ngtcp2 for their applications are impacted by CVE-2024-52811.